Skip to content

Refactor for memory consideration and add RainbowSparkle. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2020
Merged

Refactor for memory consideration and add RainbowSparkle. #20

merged 6 commits into from
May 17, 2020

Conversation

kattni
Copy link
Contributor

@kattni kattni commented May 17, 2020

Splitting everything up allows for more flexible use when there are memory considerations (as with M0).

Added RainbowSparkle animation.

FoamyGuy
FoamyGuy approved these changes May 17, 2020
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the refactored library and all 3 examples with a PyBadge and NeoPxiel Featherwing. Everything is working well as far as I can tell.

@FoamyGuy FoamyGuy merged commit 4b3475c into adafruit:master May 17, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 18, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c5c3fcd)
bbc68dd 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.0.0 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#21 from kattni/doc-example-update
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#20 from kattni/refactor
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#19 from kattni/update-blink-speed-example
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#10 from rhooper/more-magic
@kattni kattni deleted the refactor branch November 3, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kattni @FoamyGuy @rhooper